Skip to content

Convert inspector view to use PluginLogger #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Convert inspector view to use PluginLogger #8547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/io/flutter/view/InspectorView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import io.flutter.jxbrowser.InstallationFailedReason;
import io.flutter.jxbrowser.JxBrowserManager;
import io.flutter.jxbrowser.JxBrowserStatus;
import io.flutter.logging.PluginLogger;
import io.flutter.run.FlutterDevice;
import io.flutter.run.daemon.DevToolsInstance;
import io.flutter.run.daemon.DevToolsService;
Expand Down Expand Up @@ -61,7 +62,7 @@
storages = {@Storage("$WORKSPACE_FILE$")}
)
public class InspectorView implements Disposable {
private static final @NotNull Logger LOG = Logger.getInstance(InspectorView.class);
private static final @NotNull Logger LOG = PluginLogger.createLogger(InspectorView.class);

public static final @NotNull String TOOL_WINDOW_ID = "Flutter Inspector";

Expand Down Expand Up @@ -275,7 +276,7 @@ private void openInspectorWithDevTools(FlutterApp app,

// TODO(helinx): Restart DevTools server if there's an error.
if (error != null) {
LOG.error(error);
FlutterUtils.error(LOG, "Error while starting DevTools server", error, true);
viewUtils.presentLabel(toolWindow, DEVTOOLS_FAILED_LABEL);
return;
}
Expand Down