Skip to content

Move log level setup to initializer #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

Move log level setup to initializer #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dabfc9a
Move log level setup to initializer
helin24 Sep 30, 2025
e82770f
Move log setup to beginning
helin24 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/io/flutter/FlutterInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import io.flutter.devtools.RemainingDevToolsViewFactory;
import io.flutter.editor.FlutterSaveActionsManager;
import io.flutter.logging.FlutterConsoleLogManager;
import io.flutter.logging.PluginLogger;
import io.flutter.module.FlutterModuleBuilder;
import io.flutter.pub.PubRoot;
import io.flutter.pub.PubRoots;
Expand Down Expand Up @@ -82,6 +83,10 @@ public class FlutterInitializer extends FlutterProjectActivity {

@Override
public void executeProjectStartup(@NotNull Project project) {
// This sets the correct log level and listens for future changes.
PluginLogger.updateLogLevel();
FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel);

log().info("Executing Flutter plugin startup for project: " + project.getName());
// Disable the 'Migrate Project to Gradle' notification.
FlutterUtils.disableGradleProjectMigrationNotification(project);
Expand Down
7 changes: 1 addition & 6 deletions src/io/flutter/logging/PluginLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,9 @@ public class PluginLogger {

static {
rootLogger.addHandler(fileHandler);
// This check prevents trying to access settings in test context.
if (ApplicationManager.getApplication() != null) {
updateLogLevel();
FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel);
}
}

private static void updateLogLevel() {
public static void updateLogLevel() {
final Logger rootLoggerInstance = Logger.getInstance("io.flutter");
rootLoggerInstance.setLevel(FlutterSettings.getInstance().isVerboseLogging() ? LogLevel.ALL : LogLevel.INFO);
}
Expand Down