Skip to content

Commit 785392e

Browse files
test: Fix leaks in editable gesture test
1 parent d0c8ad2 commit 785392e

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

packages/flutter/test/rendering/editable_gesture_test.dart

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,21 @@ import 'package:flutter/gestures.dart';
66
import 'package:flutter/material.dart';
77
import 'package:flutter/rendering.dart';
88
import 'package:flutter_test/flutter_test.dart';
9-
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
109

1110
void main() {
1211
final TestWidgetsFlutterBinding binding = _GestureBindingSpy();
1312

14-
testWidgets('attach and detach correctly handle gesture',
15-
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787
16-
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
17-
(_) async {
13+
testWidgets('attach and detach correctly handle gesture', (_) async {
1814
expect(WidgetsBinding.instance, binding);
1915
final TextSelectionDelegate delegate = FakeEditableTextState();
16+
final ViewportOffset offset = ViewportOffset.zero();
17+
addTearDown(offset.dispose);
2018
final RenderEditable editable = RenderEditable(
2119
backgroundCursorColor: Colors.grey,
2220
selectionColor: Colors.black,
2321
textDirection: TextDirection.ltr,
2422
cursorColor: Colors.red,
25-
offset: ViewportOffset.zero(),
23+
offset: offset,
2624
textSelectionDelegate: delegate,
2725
text: const TextSpan(
2826
text: 'test',
@@ -36,13 +34,17 @@ void main() {
3634
affinity: TextAffinity.upstream,
3735
),
3836
);
37+
addTearDown(editable.dispose);
3938
editable.layout(BoxConstraints.loose(const Size(1000.0, 1000.0)));
4039

41-
final PipelineOwner owner = PipelineOwner(onNeedVisualUpdate: () { });
42-
final _PointerRouterSpy spy = GestureBinding.instance.pointerRouter as _PointerRouterSpy;
40+
final PipelineOwner owner = PipelineOwner(onNeedVisualUpdate: () {});
41+
addTearDown(owner.dispose);
42+
final _PointerRouterSpy spy =
43+
GestureBinding.instance.pointerRouter as _PointerRouterSpy;
4344
editable.attach(owner);
4445
// This should register pointer into GestureBinding.instance.pointerRouter.
45-
editable.handleEvent(const PointerDownEvent(), BoxHitTestEntry(editable, const Offset(10,10)));
46+
editable.handleEvent(const PointerDownEvent(),
47+
BoxHitTestEntry(editable, const Offset(10, 10)));
4648
GestureBinding.instance.pointerRouter.route(const PointerDownEvent());
4749
expect(spy.routeCount, greaterThan(0));
4850
editable.detach();
@@ -57,7 +59,7 @@ class _GestureBindingSpy extends AutomatedTestWidgetsFlutterBinding {
5759
PointerRouter get pointerRouter => _testPointerRouter;
5860
}
5961

60-
class FakeEditableTextState extends Fake implements TextSelectionDelegate { }
62+
class FakeEditableTextState extends Fake implements TextSelectionDelegate {}
6163

6264
class _PointerRouterSpy extends PointerRouter {
6365
int routeCount = 0;

0 commit comments

Comments
 (0)