Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template type parameter to invokeMethod calls in the plugins repo #26431

Closed
amirh opened this issue Jan 11, 2019 · 7 comments
Closed

Add template type parameter to invokeMethod calls in the plugins repo #26431

amirh opened this issue Jan 11, 2019 · 7 comments
Assignees
@cyanglaz
Labels
package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Milestone
June 2019

Comments

@amirh
Copy link
Contributor

amirh commented Jan 11, 2019

#26303 added a template argument to invokeMethod, which triggers the strong_mode_implicit_dynamic_method analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the invokeMethod change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

cc @jonahwilliams @Hixie
@amirh amirh added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin labels Jan 11, 2019
@amirh amirh added this to the Goals milestone Jan 11, 2019
amirh pushed a commit to amirh/plugins that referenced this issue Jan 11, 2019
Supress strong_mode_implicit_dynamic_method for invokeMethod calls.
e449bc4 
flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
amirh pushed a commit to amirh/plugins that referenced this issue Jan 11, 2019
Supress strong_mode_implicit_dynamic_method for invokeMethod calls.
3e6c2a1 
flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
@amirh amirh mentioned this issue Jan 11, 2019
Merged
amirh added a commit to flutter/plugins that referenced this issue Jan 12, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
4d702ad 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
@Hixie
Copy link
Contributor

Hixie commented Jan 15, 2019

Next stable release should be February or March; shall we assign this to someone and put it in the April or May milestones?

@amirh amirh modified the milestones: Goals, April 2019 Jan 15, 2019
@amirh amirh self-assigned this Jan 15, 2019
@amirh
Copy link
Contributor Author

amirh commented Jan 15, 2019

done

andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this issue Feb 17, 2019
@amirh @andreidiaconu
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
8b14bc4 
…s. (flutter#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
@cyanglaz cyanglaz mentioned this issue Mar 20, 2019
Closed
@keitoro keitoro mentioned this issue Mar 21, 2019
Closed
@amirh amirh modified the milestones: April 2019, May 2019 Mar 25, 2019
This was referenced Mar 28, 2019
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
cyanglaz pushed a commit to flutter/plugins that referenced this issue Mar 29, 2019
[Cloud_firestore]add type params for invokeMethod calls. (#1414)
d4fd64f 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.

flutter/flutter#26431
cyanglaz pushed a commit to flutter/plugins that referenced this issue Mar 29, 2019
[Camera]add type params for invokeMethod calls. (#1413)
2acf6b2 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.
flutter/flutter#26431
cyanglaz pushed a commit to flutter/plugins that referenced this issue Mar 29, 2019
[android_alarm_manager] add type params for invokeMethod calls. (#1410)
6926dc4 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.
flutter/flutter#26431
@cyanglaz cyanglaz mentioned this issue Apr 2, 2019
Closed
13 tasks
This was referenced May 31, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@cyanglaz
Copy link
Contributor

cyanglaz commented Jun 4, 2019

This is completed, closing the issue.

@cyanglaz cyanglaz closed this as completed Jun 4, 2019
collinjackson pushed a commit to collinjackson/flutterfire-old2 that referenced this issue Jun 24, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
5e7c337 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
collinjackson pushed a commit to collinjackson/flutterfire-old2 that referenced this issue Jun 24, 2019
[Cloud_firestore]add type params for invokeMethod calls. (#1414)
0f8e69c 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.

flutter/flutter#26431
collinjackson pushed a commit to firebase/flutterfire that referenced this issue Aug 14, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
340c47f 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
collinjackson pushed a commit to firebase/flutterfire that referenced this issue Aug 14, 2019
[Cloud_firestore]add type params for invokeMethod calls. (#1414)
9e56533 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.

flutter/flutter#26431
g123k pushed a commit to g123k/flutter_android_intent_with_parts that referenced this issue Sep 4, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
b13aa56 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
ifananomali pushed a commit to ifananomali/camera that referenced this issue Sep 12, 2019
[Camera]add type params for invokeMethod calls. (#1413)
d5a4a1b 
Bump min flutter version to 1.2.0.
Add template type parameter for invokeMethod calls.
Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod if any.
flutter/flutter#26431
Akachu pushed a commit to Akachu/firebase_auth that referenced this issue Sep 16, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
ead6ea2 
…s. (firebase#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
ryanheise pushed a commit to ryanheise/background_video_player that referenced this issue Sep 29, 2019
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
dfa3cf9 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
nksteven pushed a commit to nksteven/ntf-firebase_messaging that referenced this issue Apr 8, 2020
@amirh
Supress strong_mode_implicit_dynamic_method for invokeMethod call…
13e0370 
…s. (#1065)

flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo.

We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release.

For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)

See: flutter/flutter#26431
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
4 participants
@Hixie @amirh @cyanglaz @lizhuoyuan