Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Add missing template type parameter to invokeMethod calls. Bump minimum Flutter version to 1.5.0. Replace invokeMethod with invokeMapMethod wherever necessary. #1681

Merged
merged 1 commit into from
Jun 4, 2019
Merged

[google_sign_in] Add missing template type parameter to invokeMethod calls. Bump minimum Flutter version to 1.5.0. Replace invokeMethod with invokeMapMethod wherever necessary. #1681

merged 1 commit into from
Jun 4, 2019

Conversation

cyanglaz
Copy link
Contributor

Add missing template type parameter to calls. Bump minimum Flutter ve…
5cdb34d 
…rsion to 1.5.0. Replace invokeMethod with invokeMapMethod wherever necessary.
@cyanglaz cyanglaz requested a review from mehmetf as a code owner May 31, 2019 23:31
iskakaushik
iskakaushik approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 9dfc970 into flutter:master Jun 4, 2019
@cyanglaz cyanglaz deleted the google_sign_in branch June 4, 2019 01:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehmetf mehmetf Awaiting requested review from mehmetf

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @iskakaushik @googlebot