Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exports public API types from scheduler/*.dart #105737

Merged
merged 1 commit into from
Jun 9, 2022
Merged

exports public API types from scheduler/*.dart #105737

merged 1 commit into from
Jun 9, 2022

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Jun 9, 2022

Related to dart-lang/linter#3391 this PR exports public API types from scheduler/*.dart library.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 9, 2022
@a14n a14n requested a review from Hixie June 9, 2022 20:40
Hixie
Hixie approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

text-exempt: refactor with no semantic change

@fluttergithubbot fluttergithubbot merged commit 1b65ba5 into flutter:master Jun 9, 2022
@a14n a14n deleted the export-public-api branch June 10, 2022 05:50
This was referenced Jun 10, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
1345d73 
…tter#105737)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
3def2f7 
…er#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
f0c4d2d 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
3a97035 
…er#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
03755d3 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
1292742 
…er#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
76f4488 
…er#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
f9383f4 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
fa3fa80 
…tter#105737)
This was referenced Jun 11, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
173be02 
…tter#105737)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
969bf4a 
…er#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
c132178 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
3e8e56c 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
e9ca924 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
00eab81 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
1fff823 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
17c4a7b 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
2ece920 
…tter#105737)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
e95acd2 
…tter#105737)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@a14n @camsim99
exports public API types from scheduler/*.dart (flutter#105737)
9c19f20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
1b65ba538 exports public API types from scheduler/*.dart (flutter/flu…
460d14f 
…tter#105737)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
1b65ba5 exports public API types from scheduler/*.dart (flutter/flutt…
104f944 
…er#105737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a14n @Hixie @fluttergithubbot