Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leak track cupertino widgets #135353

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Leak track cupertino widgets #135353

merged 2 commits into from
Oct 1, 2023

Conversation

derdilla
Copy link
Contributor

Adds leak tracking to cupertino/scaffold_test.dart as well as cupertino/nav_bar_test.dart and fix leaks (#134).

Each file has a test case that has not been covered yet, as they depend on #134661 to be fixed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 23, 2023
@ksokolovskyi
Copy link
Contributor

@polina-c, could you please take a look at this PR?

@polina-c polina-c self-requested a review October 1, 2023 23:41
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 1, 2023
@polina-c polina-c merged commit 994f71c into flutter:master Oct 1, 2023
66 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
994f71c Leak track cupertino widgets (flutter/flutter#135353)
f9de8e7
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
Roll Flutter from d42313c to 57ed724 (11 revisions) (#5059)
d6c854c 
flutter/flutter@d42313c...57ed724

2023-10-02 58190796+MitchellGoodwin@users.noreply.github.com Update dialog tests for Material3 (flutter/flutter#135775)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1410d689bd0a to 321139f5821e (2 revisions) (flutter/flutter#135843)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b63d286b51a to 1410d689bd0a (1 revision) (flutter/flutter#135840)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9ccf85f09e73 to 8b63d286b51a (1 revision) (flutter/flutter#135838)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10b930ad1adf to 9ccf85f09e73 (1 revision) (flutter/flutter#135837)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com Test cover cupertino text field for memory leaks. (flutter/flutter#135804)
2023-10-02 sokolovskyi.konstantin@gmail.com Fix memory leaks in WidgetInspector and WidgetInspectorService. (flutter/flutter#135828)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com leak track page_test.dart (flutter/flutter#135352)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from fff38de45ef7 to 10b930ad1adf (1 revision) (flutter/flutter#135835)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com Leak track cupertino widgets (flutter/flutter#135353)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 310ad4666445 to fff38de45ef7 (1 revision) (flutter/flutter#135830)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@derdilla @Mairramer
Leak track cupertino widgets (flutter#135353)
e7c18d7
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from d42313c to 57ed724 (11 revisions) (flutter#5059)
1852cf5 
flutter/flutter@d42313c...57ed724

2023-10-02 58190796+MitchellGoodwin@users.noreply.github.com Update dialog tests for Material3 (flutter/flutter#135775)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1410d689bd0a to 321139f5821e (2 revisions) (flutter/flutter#135843)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b63d286b51a to 1410d689bd0a (1 revision) (flutter/flutter#135840)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9ccf85f09e73 to 8b63d286b51a (1 revision) (flutter/flutter#135838)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10b930ad1adf to 9ccf85f09e73 (1 revision) (flutter/flutter#135837)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com Test cover cupertino text field for memory leaks. (flutter/flutter#135804)
2023-10-02 sokolovskyi.konstantin@gmail.com Fix memory leaks in WidgetInspector and WidgetInspectorService. (flutter/flutter#135828)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com leak track page_test.dart (flutter/flutter#135352)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from fff38de45ef7 to 10b930ad1adf (1 revision) (flutter/flutter#135835)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com Leak track cupertino widgets (flutter/flutter#135353)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 310ad4666445 to fff38de45ef7 (1 revision) (flutter/flutter#135830)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derdilla @ksokolovskyi @polina-c