Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextStyle terminology #137000

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix TextStyle terminology #137000

merged 1 commit into from
Oct 23, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

cascading -> inheritance

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 21, 2023
goderbauer
goderbauer approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023
@auto-submit auto-submit bot merged commit 117c709 into flutter:master Oct 23, 2023
62 checks passed
@LongCatIsLooong LongCatIsLooong deleted the fix-textstyle-terminology branch October 23, 2023 17:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
c334b07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
df0c9d3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
49aac8c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
4c01544
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
8bbecac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
f680cba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
117c709 Fix TextStyle terminology (flutter/flutter#137000)
592ad3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LongCatIsLooong @goderbauer