-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAR] [a11y] Update text button page in a11y assessment app #148905
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
8c90aa8
to
b31ed1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/148905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
update text button
5a35707
to
b0213b4
Compare
auto label is removed for flutter/flutter/148905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…148905) internal: b/317125569 If the text button label contains its role and state, it will be confusing for tester. it will be announced like "xxx button button" : <img src="https://github.com/flutter/flutter/assets/108393416/16f5a996-b0f1-4f04-bd99-caa3cacd4182" width=50% height=50%> updated screen and label: <img src="https://github.com/flutter/flutter/assets/108393416/1de55cec-8a18-4c36-9dac-84ae7d151fd6" width=50% height=50%>
internal: b/317125569
If the text button label contains its role and state, it will be confusing for tester.
it will be announced like "xxx button button" :
updated screen and label:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.