Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" #62147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
team
|
|
||
| // We absolutely must dispose this vmService instance, otherwise | ||
| // DDS will fail to start. | ||
| vmService.dispose(); |
There was a problem hiding this comment.
nit: don't use "we"
Can this be tested somehow?
There was a problem hiding this comment.
I'm not sure if it's worth testing here since it's tested in the SDK, but DDS will throw an exception if another client is already connected to the VM service.
There was a problem hiding this comment.
I suppose if this were accidentally removed, the devicelab tests would already be failing.
There was a problem hiding this comment.
Yeah, the last time I tried to land this after I stopped swallowing the exception I found this issue. The iOS devicelab tests were very unhappy so it'd be hard to miss.
…` when launching on iOS devices, causing DDS to fail to start - Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
…ls (flutter#61276)" (flutter#62147) This reverts commit adc9dde. - Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start - Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…ls (flutter#61276)" (flutter#62147) This reverts commit adc9dde. - Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start - Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit adc9dde.
Changes for attempt 6 (see diff between commits):
FallbackDiscoverywould hold on to aVmServicewhen launching on iOS devices, causing DDS to fail to startflutter drivecase where DDS is already running in another flutter_tools instance