Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Fonts] Update material icons (#78311)" #79058

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Revert "[Fonts] Update material icons (#78311)" #79058

merged 1 commit into from
Mar 25, 2021

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Mar 25, 2021

This reverts commit e34f3b0.

Developers have reported a disconnect between the Icons class and the actual icon font. Reverting #78311 while I investigate

#79042
#79020

@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Mar 25, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manjunath093
Copy link

iphone release build is showing wrong icons in emulator it is showing correct icons
expected icons is forward_ios_arrow
but wrong icon is getting folder_special

flutter doctor -v results

[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-x64, locale en-GB)
• Flutter version 2.5.3 at /Users/manjup/Downloads/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 1811693 (6 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/manjup/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"

[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:

@guidezpl
Copy link
Member Author

Please create a new issue and @ me. Also please indicate the contents of flutter/bin/cache/material_fonts.stamp

@flutter flutter locked and limited conversation to collaborators Nov 29, 2021
@guidezpl guidezpl deleted the revert-update-icons branch December 24, 2021 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants