Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Rotation doesn't work in 2D transformations demo #967

Closed
1 task done
rorystephenson opened this issue Jun 9, 2023 · 1 comment · Fixed by #968
Closed
1 task done

Rotation doesn't work in 2D transformations demo #967

rorystephenson opened this issue Jun 9, 2023 · 1 comment · Fixed by #968
Assignees
Labels
bug Something isn't working triage

Comments

@rorystephenson
Copy link

Existing issue?

What happened?

Expected vs actual result:

Two finger rotate should rotate the the scene (as described when tapping the info button), it does not.

Tested on:

  1. Latest master (d77920b) with flutter master (flutter doctor output below).
  2. Flutter Gallery Android app using real Android device (according to the 'About Flutter Gallery' dialog it is version 2.9.2).

Steps to reproduce:

  1. Open 2D transformations demo (Styles & Transformations > 2D Transformations).
  2. Try to two-finger rotate.

Relevant log output

[✓] Flutter (Channel master, 3.12.0-3.0.pre.31, on macOS 12.5.1 21G83 darwin-arm64, locale en-NZ)
    • Flutter version 3.12.0-3.0.pre.31 on channel master at /Users/rorystephenson/sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 192b06405b (49 minutes ago), 2023-06-09 11:04:07 +0300
    • Engine revision 8f9e608d39
    • Dart version 3.1.0 (build 3.1.0-180.0.dev)
    • DevTools version 2.24.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/rorystephenson/sdk/android
    • Platform android-33, build-tools 33.0.1
    • ANDROID_HOME = /Users/rorystephenson/sdk/android
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 12.5.1 21G83 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 111.0.5563.110

[✓] Network resources
    • All expected network resources are available.

• No issues found!
@rorystephenson rorystephenson added bug Something isn't working triage labels Jun 9, 2023
@guidezpl
Copy link
Member

guidezpl commented Jun 9, 2023

cc @justinmc

@justinmc justinmc self-assigned this Jun 9, 2023
guidezpl added a commit that referenced this issue Jul 1, 2023
…mplemented (#968)

## Description

The transformation demo does not include rotation, but the description
and subtitle says it does. This PR removes mention of rotation.

Rotation is not currently supported by InteractiveViewer under the hood,
though someday I'd like it to!

@guidezpl What's the process for updating an existing string like this?
I couldn't figure it out by reading the [l10n
readme](https://github.com/flutter/gallery/tree/main/lib/l10n#readme).

## Tests

None.

## Issues
Fixes #967

---------

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants