Setup packages repo for CI, update analysis options #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit-mit
reviewed
Jun 15, 2018
| @@ -0,0 +1,93 @@ | |||
| Contributing to Flutter | |||
There was a problem hiding this comment.
Rather than duplicating this, I suggest we link to it, similar to what we do over in flutter/plugins: https://github.com/flutter/plugins#contributing
There was a problem hiding this comment.
OK. There is some specific stuff here for the packages repo, but I'll just factor that out.
There was a problem hiding this comment.
Actually the link you gave is to README.md in the plugins dir. The CONTRIBUTING.md there is basically the same as here (I did start from that one to make this one). This one is customized for the packages repo.
I'll update the README.md to be like the one in plugins.
Hixie
reviewed
Jun 15, 2018
| # IntelliJ, Android Studio, and the 'flutter analyze' command. | ||
| # | ||
| # This file is derived from the master file in the flutter repo, and should be | ||
| # kept in sync with it. |
There was a problem hiding this comment.
we should be able to do a relative import rather than duplicating this
if you can figure out how to make that work, we can then also apply that to the other places where we duplicate this
There was a problem hiding this comment.
Yeah, I'd love to do that, but I have no idea how to do relative imports here, or how to reference something in the flutter dir (wherever it is). I've looked at the docs for the analysis options, and it doesn't say anything about imports.
|
licenses? |
|
There's already a LICENSE file. Was there something else I needed to add? |
|
Note that the LICENSE file already existed before this PR, so it's not in this PR. |
gspencergoog
force-pushed
the
setup_ci
branch
6 times, most recently
from
30a84a6
to
53e7b7e
Compare
Hixie
reviewed
Jun 18, 2018
README.md
Outdated
| @@ -1,4 +1,37 @@ | |||
| # Helpful packages for Flutter | |||
| # Flutter plugins | |||
|
Please update the license to match the one in the flutter/flutter repo. Then, LGTM. |
gspencergoog
force-pushed
the
setup_ci
branch
2 times, most recently
from
7ff51fa
to
2030eb6
Compare
|
Looks like I don't have write access either |
stuartmorgan
referenced
this pull request
in stuartmorgan/packages
Apr 27, 2021
create a lib/ directory
stuartmorgan
referenced
this pull request
in stuartmorgan/packages
Apr 29, 2021
Add environment to make css_colors work with Dart 2.1.0
stuartmorgan
referenced
this pull request
in stuartmorgan/packages
Apr 30, 2021
create a lib/ directory
stuartmorgan
referenced
this pull request
in stuartmorgan/packages
May 12, 2021
* setup repo from the template w/Travis * unhardcode path to flutter * split out pub get; analyze specific dirs; print commands * update .analysis_options header
austinstoker
pushed a commit
to austinstoker/packages
that referenced
this pull request
Apr 29, 2022
merge new updates
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 24, 2022
junaid1460
referenced
this pull request
Aug 23, 2022
* Refactor internal classes and methods - Separate matching from redirection - Add RouteRedirector typedef - Add RouteMatcher class - Add RouteBuilder class - Add RouteConfiguration class - Rename and reorganize internal classes and libraries - Add todo comments * format * Sort imports * Update changelog * Address code review comments - Change name back to GoRouterRefreshStream - Update toString() methods for new naming - Make fields final - Add logging to parser - Add comments - add tests - Move function-scope to new library-scope _addRedirect function - import widgets instead of material where possible * remove routing library * Move classes in go_router.dart into separate libraries * Move Configuration.validate() into constructor * Remove comment * use continue in redirect loop * Fix comments * Sort imports * Fix logging in configuration * add visibleForTesting annotation * Updates from merge with main * Format * Add TODOs to make Router implementation classes private * Add copyright headers * Fix tests * format * fix comment * Update packages/go_router/lib/src/parser.dart Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> * add whitespace * format * Hide typedefs that weren't previously exported * Delete empty file * add missing import * Specify version 4.1.2 in pubspec.yaml * Update packages/go_router/lib/src/builder.dart Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> * Fix comment * Add isError and error getters to RouteMatchList * Add issue links to TODO comments * Add link to issue for TODO * Re-apply code from #2306 due to merge conflicts * Add issue references Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
flutter/flutter@f52fe4f...83134ac 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b3f9886fbf0 to 60e861dfe6b1 (1 revision) (flutter/flutter#136264) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from e354a13cfeab to 2b3f9886fbf0 (4 revisions) (flutter/flutter#136259) 2023-10-10 engine-flutter-autoroll@skia.org Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter/flutter#136258) 2023-10-10 sokolovskyi.konstantin@gmail.com RenderAnnotatedRegion should dispose created layers. (flutter/flutter#136086) 2023-10-10 polinach@google.com TestClipPaintingContext should dispose ContainerLayer (flutter/flutter#135949) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aa7cb057d22 to e354a13cfeab (1 revision) (flutter/flutter#136248) 2023-10-10 104349824+huycozy@users.noreply.github.com Migrate the "Non-speed related performance issues" issue template to Github forms (flutter/flutter#135130) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 171b4b26e68b to 9aa7cb057d22 (4 revisions) (flutter/flutter#136240) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d094401acb99 to 171b4b26e68b (1 revision) (flutter/flutter#136235) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92880e9847b3 to d094401acb99 (1 revision) (flutter/flutter#136233) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51193f8f53eb to 92880e9847b3 (1 revision) (flutter/flutter#136232) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f2fa3ceb8a0 to 51193f8f53eb (4 revisions) (flutter/flutter#136228) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73da593bac54 to 8f2fa3ceb8a0 (2 revisions) (flutter/flutter#136220) 2023-10-09 chillers@google.com [conductor] Remove PublishChannel and use MPA command (flutter/flutter#135884) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0966f62d7101 to 73da593bac54 (1 revision) (flutter/flutter#136216) 2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/painting #1 (flutter/flutter#136167) 2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Cover testwidgets with leak tracking in test/gestures (flutter/flutter#136166) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 81e5bf29dee4 to 0966f62d7101 (1 revision) (flutter/flutter#136215) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22ce5c6a45e2 to 81e5bf29dee4 (3 revisions) (flutter/flutter#136211) 2023-10-09 110993981+htoor3@users.noreply.github.com [web] Fix `page up` `page down` `home` `end` shortcut behavior on web (flutter/flutter#135454) 2023-10-09 gspencergoog@users.noreply.github.com Update `MediaQuery` documentation to highlight asynchronous nature of size (flutter/flutter#135719) 2023-10-09 47866232+chunhtai@users.noreply.github.com Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rou� (flutter/flutter#134554) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) (flutter/flutter#136205) 2023-10-09 engine-flutter-autoroll@skia.org Roll Packages from e578a16 to 7de08ec (4 revisions) (flutter/flutter#136202) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 664f5e833871 to 429a242b0db6 (2 revisions) (flutter/flutter#136201) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
flutter/flutter@f52fe4f...83134ac 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b3f9886fbf0 to 60e861dfe6b1 (1 revision) (flutter/flutter#136264) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from e354a13cfeab to 2b3f9886fbf0 (4 revisions) (flutter/flutter#136259) 2023-10-10 engine-flutter-autoroll@skia.org Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter/flutter#136258) 2023-10-10 sokolovskyi.konstantin@gmail.com RenderAnnotatedRegion should dispose created layers. (flutter/flutter#136086) 2023-10-10 polinach@google.com TestClipPaintingContext should dispose ContainerLayer (flutter/flutter#135949) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aa7cb057d22 to e354a13cfeab (1 revision) (flutter/flutter#136248) 2023-10-10 104349824+huycozy@users.noreply.github.com Migrate the "Non-speed related performance issues" issue template to Github forms (flutter/flutter#135130) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 171b4b26e68b to 9aa7cb057d22 (4 revisions) (flutter/flutter#136240) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d094401acb99 to 171b4b26e68b (1 revision) (flutter/flutter#136235) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92880e9847b3 to d094401acb99 (1 revision) (flutter/flutter#136233) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51193f8f53eb to 92880e9847b3 (1 revision) (flutter/flutter#136232) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f2fa3ceb8a0 to 51193f8f53eb (4 revisions) (flutter/flutter#136228) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73da593bac54 to 8f2fa3ceb8a0 (2 revisions) (flutter/flutter#136220) 2023-10-09 chillers@google.com [conductor] Remove PublishChannel and use MPA command (flutter/flutter#135884) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0966f62d7101 to 73da593bac54 (1 revision) (flutter/flutter#136216) 2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/painting flutter#1 (flutter/flutter#136167) 2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Cover testwidgets with leak tracking in test/gestures (flutter/flutter#136166) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 81e5bf29dee4 to 0966f62d7101 (1 revision) (flutter/flutter#136215) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22ce5c6a45e2 to 81e5bf29dee4 (3 revisions) (flutter/flutter#136211) 2023-10-09 110993981+htoor3@users.noreply.github.com [web] Fix `page up` `page down` `home` `end` shortcut behavior on web (flutter/flutter#135454) 2023-10-09 gspencergoog@users.noreply.github.com Update `MediaQuery` documentation to highlight asynchronous nature of size (flutter/flutter#135719) 2023-10-09 47866232+chunhtai@users.noreply.github.com Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rou� (flutter/flutter#134554) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) (flutter/flutter#136205) 2023-10-09 engine-flutter-autoroll@skia.org Roll Packages from e578a16 to 7de08ec (4 revisions) (flutter/flutter#136202) 2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 664f5e833871 to 429a242b0db6 (2 revisions) (flutter/flutter#136201) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding a package to this, I'm turning on Travis CI for this repo and updating the analysis options and adding a
CONTRIBUTING.md.