Skip to content

[shared_preferences] updates build files to use JVM 17 #10131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
+26 −20
Merged

[shared_preferences] updates build files to use JVM 17 #10131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1ab25e
jvm 17
AbdeMohlbi Sep 30, 2025
60d73fa
Merge branch 'main' into shared_preferences_jvm_17
AbdeMohlbi Sep 30, 2025
d9cf19d
Update packages/shared_preferences/shared_preferences_android/android…
reidbaker Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/shared_preferences/shared_preferences_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.4.14

* Updates Java compatibility version to 17.
* Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.

## 2.4.13

* Bumps androidx.datastore:datastore from 1.1.3 to 1.1.7.
Expand Down
6 changes: 3 additions & 3 deletions packages/shared_preferences/shared_preferences_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ android {
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '11'
jvmTarget = JavaVersion.VERSION_17.toString()
}

sourceSets {
Expand Down
6 changes: 3 additions & 3 deletions packages/shared_preferences/shared_preferences_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ android {
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
}

sourceSets {
Expand Down
5 changes: 3 additions & 2 deletions packages/shared_preferences/shared_preferences_android/lib/src/messages.g.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ class SharedPreferencesApi {
BinaryMessenger? binaryMessenger,
String messageChannelSuffix = '',
}) : pigeonVar_binaryMessenger = binaryMessenger,
pigeonVar_messageChannelSuffix =
messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
pigeonVar_messageChannelSuffix = messageChannelSuffix.isNotEmpty
? '.$messageChannelSuffix'
: '';
final BinaryMessenger? pigeonVar_binaryMessenger;

static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
Expand Down
5 changes: 3 additions & 2 deletions packages/shared_preferences/shared_preferences_android/lib/src/messages_async.g.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ class SharedPreferencesAsyncApi {
BinaryMessenger? binaryMessenger,
String messageChannelSuffix = '',
}) : pigeonVar_binaryMessenger = binaryMessenger,
pigeonVar_messageChannelSuffix =
messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
pigeonVar_messageChannelSuffix = messageChannelSuffix.isNotEmpty
? '.$messageChannelSuffix'
: '';
final BinaryMessenger? pigeonVar_binaryMessenger;

static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
Expand Down
6 changes: 3 additions & 3 deletions packages/shared_preferences/shared_preferences_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: shared_preferences_android
description: Android implementation of the shared_preferences plugin
repository: https://github.com/flutter/packages/tree/main/packages/shared_preferences/shared_preferences_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22
version: 2.4.13
version: 2.4.14

environment:
sdk: ^3.7.0
flutter: ">=3.29.0"
sdk: ^3.9.0
flutter: ">=3.35.0"

flutter:
plugin:
Expand Down
13 changes: 6 additions & 7 deletions ...ges/shared_preferences/shared_preferences_android/test/shared_preferences_async_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ void main() {

final SharedPreferencesAsyncAndroidOptions emptyOptions =
SharedPreferencesAsyncAndroidOptions(
backend:
useDataStore
? SharedPreferencesAndroidBackendLibrary.DataStore
: SharedPreferencesAndroidBackendLibrary.SharedPreferences,
backend: useDataStore
? SharedPreferencesAndroidBackendLibrary.DataStore
: SharedPreferencesAndroidBackendLibrary.SharedPreferences,
);

test('set and get String with $backend', () async {
Expand Down Expand Up @@ -337,9 +336,9 @@ class _FakeSharedPreferencesApi implements SharedPreferencesAsyncApi {
return value == null
? null
: StringListResult(
jsonEncodedValue: value as String?,
type: StringListLookupResultType.jsonEncoded,
);
jsonEncodedValue: value as String?,
type: StringListLookupResultType.jsonEncoded,
);
}

@override
Expand Down