Add Versioning to Gradle 9 Deprecation Change #10187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesswrd
requested review from
bparrishMines,
ash2moon,
gmackall,
camsim99,
mboetger and
reidbaker
as code owners
github-actions
bot
added
p: camera
p: espresso
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates multiple packages to resolve Gradle 9 deprecations. The changes involve bumping package versions in pubspec.yaml files and adding corresponding entries to CHANGELOG.md files.
My review found several issues with the CHANGELOG.md files:
- In some cases, a new version is inserted into the middle of the changelog history, which is incorrect. New versions should always be at the top.
- In other cases, the changelog entry for the new version is swapped with an older one.
I've left specific comments on the affected files with suggestions for correction.
Additionally, it seems that for some packages where the CHANGELOG.md was updated, the corresponding pubspec.yaml file was not included in the pull request. Please ensure that for every updated changelog, the pubspec.yaml version is also bumped and included in the PR.
packages/shared_preferences/shared_preferences_android/CHANGELOG.md
Outdated
Show resolved
Hide resolved
11 tasks
stuartmorgan-g
requested changes
Oct 8, 2025
reidbaker
reviewed
Oct 8, 2025
reidbaker
approved these changes
Oct 8, 2025
Yes this is intentional and there are no code changes in the packages. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2025
flutter/packages@8ca6416...260f381 2025-10-08 jessiewong401@gmail.com Add Versioning to Gradle 9 Deprecation Change (flutter/packages#10187) 2025-10-07 julien@delarbre.biz [camera_avfoundation] iOS: Fix crash when `enableAudio == false` by correcting guard condition (flutter/packages#9949) 2025-10-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.fragment:fragment from 1.8.8 to 1.8.9 in /packages/local_auth/local_auth_android/android (flutter/packages#10111) 2025-10-07 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for accessing data for an Ad (flutter/packages#9972) 2025-10-07 stuartmorgan@google.com [webview_flutter] Add Android geolocation README (flutter/packages#10166) 2025-10-07 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.4.8-android to 33.5.0-android in /packages/espresso/android (flutter/packages#10047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Flutter clients use published plugins that depend on other outdated/older plugins with an app using Gradle 9, they will be using outdated Gradle 9 deprecated patterns (in
build.gradle). To ensure usage of resolved deprecated build.gradle files, Flutter clients can specify the pub version in this PR.Should have included versioning and changelog in this PR: #10016
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3