Skip to content

Conversation

reidbaker
Copy link
Contributor

Part 1/2 for flutter/flutter/issues/176027

CHANGELOG exemption: Example apps only. #10186 (comment)
Tool test will come in part 2 after the non examples have been updated.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Java compile options to version 17 for a large number of example applications. The changes are generally correct, but I've identified a few inconsistencies. Two files set the jvmTarget for Kotlin differently from the rest, and one file is missing the compileOptions block altogether, which is the main purpose of this PR. My review comments provide suggestions to address these for consistency and completeness.

Comment on lines 33 to 35
kotlinOptions {
jvmTarget = '11'
jvmTarget = JavaVersion.VERSION_17.toString()
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This file is missing the compileOptions block to set the Java source and target compatibility to version 17. To complete the update for this example app, please add the following block, preferably before kotlinOptions:

    compileOptions {
        sourceCompatibility = JavaVersion.VERSION_17
        targetCompatibility = JavaVersion.VERSION_17
    }

@reidbaker reidbaker force-pushed the i176027_attempt_3_examples branch from b14dac0 to e6d98c0 Compare October 9, 2025 14:33
@reidbaker reidbaker added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 9, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2025
@auto-submit auto-submit bot merged commit e319c40 into flutter:main Oct 9, 2025
80 checks passed
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the README change technically requires a version bump, but it looks like this change won't affect clients anyways. So I'm fine with not needing to publish this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants