Skip to content

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Oct 10, 2025

Hold review/merge until #10201 has merged.
This pr is code review feedback from #10201 (comment)

  • Update gradle-check to support minimum java version and validating java version alignment

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@github-actions github-actions bot added the p: interactive_media_ads Plugin for IMA SDK label Oct 10, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Java compatibility version to 17 across multiple Android packages and enhances the gradle-check tool to enforce this new minimum version and ensure version alignment within build.gradle files. The changes also include numerous formatting updates in Dart files, likely from an auto-formatter.

My review focuses on the new validation logic in gradle-check. While the new checks are a great improvement, I've identified a potential issue in how Java versions are parsed, which could lead to incorrect validation in some edge cases. I've provided a suggestion to make the parsing more robust.

@reidbaker reidbaker marked this pull request as draft October 14, 2025 17:50
@github-actions github-actions bot removed the p: interactive_media_ads Plugin for IMA SDK label Oct 14, 2025
@reidbaker reidbaker marked this pull request as ready for review October 14, 2025 18:33
@gmackall gmackall changed the title [tool] Change gradle-check logic to enforce alignemnt of java versions and a minimum (17) [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant