Skip to content

_OpenContainerRoute extends PageRoute #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

_OpenContainerRoute extends PageRoute #238

wants to merge 1 commit into from

Conversation

danielgorka
Copy link

Change _OpenContainerRoute to extends PageRoute.
When extending ModalRoute the hero animations are not working, because hero checks for PageRoute.

Issue: #flutter/flutter#51337

@google-cla
Copy link

google-cla bot commented Nov 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@danielgorka
Copy link
Author

@googlebot I signed it!

@goderbauer
Copy link
Member

@danielgorka looks like this change is causing test failures. Can you look at those? In addition, this change also needs tests. Can you please add some? Thanks.

@danielgorka danielgorka deleted the patch-1 branch January 19, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants