Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[in_app_purchase] Bump in_app_purchase_android dependency to 3.0.0 #4065

Merged
merged 2 commits into from
May 23, 2023
Merged

[in_app_purchase] Bump in_app_purchase_android dependency to 3.0.0 #4065

merged 2 commits into from
May 23, 2023

Conversation

JeroenWeener
Copy link
Contributor

@JeroenWeener JeroenWeener commented May 23, 2023 •
edited
Loading

Bumps in_app_purchase_android to 3.0.0.

This PR is the final step for closing flutter/flutter#110909.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@JeroenWeener JeroenWeener changed the title [in_app_purchase] Bump Android dependency to 3.0.0 [in_app_purchase] Bump in_app_purchase_android dependency to 3.0.0 May 23, 2023
@Hixie
Copy link
Contributor

Hixie commented May 23, 2023

test-exempt: migrating for roll

bparrishMines
bparrishMines approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @stuartmorgan for secondary review

stuartmorgan
stuartmorgan approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2023
@auto-submit auto-submit bot merged commit c43cc13 into flutter:main May 23, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
c43cc13 [in_app_purchase] Bump in_app_purchase_android dependency t…
47d280f 
…o 3.0.0 (flutter/packages#4065)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from d449a17 to fba97fa (4 revisions) (#127492)
ff8411d 
flutter/packages@d449a17...fba97fa

2023-05-24 godofredoc@google.com Update infra reviewers and add label. (flutter/packages#4068)
2023-05-23 JeroenWeener@users.noreply.github.com [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065)
2023-05-23 stuartmorgan@google.com [in_app_purchase] Fix Java lints (flutter/packages#4032)
2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 3437189 to f86c529 (22 revisions) (flutter/packages#4066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from d449a17 to fba97fa (4 revisions) (flutter#127492)
c9264b4 
flutter/packages@d449a17...fba97fa

2023-05-24 godofredoc@google.com Update infra reviewers and add label. (flutter/packages#4068)
2023-05-23 JeroenWeener@users.noreply.github.com [in_app_purchase] Bump `in_app_purchase_android` dependency to 3.0.0 (flutter/packages#4065)
2023-05-23 stuartmorgan@google.com [in_app_purchase] Fix Java lints (flutter/packages#4032)
2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 3437189 to f86c529 (22 revisions) (flutter/packages#4066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kinex
Copy link

kinex commented May 27, 2023

Too late but I think this PR had breaking changes, so it should have updated major version number. Now it breaks the build if you upgrade packages (without major version upgrade).

@stuartmorgan
Copy link
Contributor

Too late but I think this PR had breaking changes

It's not too late; we have the ability to retract a package version on pub.dev. I don't see any exports of anything that changed though, so I'm not seeing how it's breaking.

Now it breaks the build if you upgrade packages

Please file an issue during an example app that imports only this package that is broken by this change, and we can follow up there.

@kinex
Copy link

kinex commented May 28, 2023

I filed an issue here flutter/flutter#127766. Anyway, thanks for this PR! It has changes I have waited for a long time. Now just have to figure out how to get them into use...

@enricoi

This comment was marked as off-topic.

Sign in to view
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: in_app_purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeroenWeener @Hixie @kinex @stuartmorgan @enricoi @bparrishMines