Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change firebase device tests from Android api 30 to 33 #5185

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Oct 19, 2023

Changes firebase device tests to use android 13. I know there is consideration for turning them off, but as long as we are running them we may as well run them on as new an android version as we can (I'm assuming here we can't use android 14 due to the ongoing work to fix some tests on android 14).

The particular device is listed as high capacity. The list can be seen here in the 3rd option without any login https://firebase.google.com/docs/test-lab/android/available-testing-devices

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall changed the title Update android_device_tests.yaml to use oriole, api33 Change firebase device tests from Android api 30 to 33 Oct 19, 2023
@gmackall gmackall marked this pull request as ready for review October 19, 2023 21:51
@gmackall gmackall requested review from stuartmorgan and a team October 19, 2023 21:51
@gmackall
Copy link
Member Author

Looks like some of the tests are crashing:
https://firebase.corp.google.com/project/flutter-infra-staging/testlab/histories/bh.f0c4b6b33369b76c/matrices/6765981869497117946/executions/bs.41e768e369e03d1c

java.lang.RuntimeException: native_reset failed.
     FATAL EXCEPTION: CameraBackground
Process: io.flutter.plugins.cameraexample, PID: 19902
java.lang.RuntimeException: native_reset failed.
	at android.media.MediaRecorder.native_reset(Native Method)
	at android.media.MediaRecorder.reset(MediaRecorder.java:1382)
	at io.flutter.plugins.camera.Camera.close(Camera.java:1246)
	at io.flutter.plugins.camera.Camera$1.onOpened(Camera.java:336)
	at android.hardware.camera2.impl.CameraDeviceImpl$1.run(CameraDeviceImpl.java:174)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.os.HandlerThread.run(HandlerThread.java:67)

@gmackall gmackall marked this pull request as draft October 19, 2023 22:36
@camsim99
Copy link
Contributor

Looks like some of the tests are crashing: https://firebase.corp.google.com/project/flutter-infra-staging/testlab/histories/bh.f0c4b6b33369b76c/matrices/6765981869497117946/executions/bs.41e768e369e03d1c

java.lang.RuntimeException: native_reset failed.
     FATAL EXCEPTION: CameraBackground
Process: io.flutter.plugins.cameraexample, PID: 19902
java.lang.RuntimeException: native_reset failed.
	at android.media.MediaRecorder.native_reset(Native Method)
	at android.media.MediaRecorder.reset(MediaRecorder.java:1382)
	at io.flutter.plugins.camera.Camera.close(Camera.java:1246)
	at io.flutter.plugins.camera.Camera$1.onOpened(Camera.java:336)
	at android.hardware.camera2.impl.CameraDeviceImpl$1.run(CameraDeviceImpl.java:174)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.os.HandlerThread.run(HandlerThread.java:67)

I believe this is a flake: flutter/flutter#129223

@gmackall
Copy link
Member Author

Looks like some of the tests are crashing: https://firebase.corp.google.com/project/flutter-infra-staging/testlab/histories/bh.f0c4b6b33369b76c/matrices/6765981869497117946/executions/bs.41e768e369e03d1c

java.lang.RuntimeException: native_reset failed.
     FATAL EXCEPTION: CameraBackground
Process: io.flutter.plugins.cameraexample, PID: 19902
java.lang.RuntimeException: native_reset failed.
	at android.media.MediaRecorder.native_reset(Native Method)
	at android.media.MediaRecorder.reset(MediaRecorder.java:1382)
	at io.flutter.plugins.camera.Camera.close(Camera.java:1246)
	at io.flutter.plugins.camera.Camera$1.onOpened(Camera.java:336)
	at android.hardware.camera2.impl.CameraDeviceImpl$1.run(CameraDeviceImpl.java:174)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.os.HandlerThread.run(HandlerThread.java:67)

I believe this is a flake: flutter/flutter#129223

Looks like it was, thanks!

@gmackall gmackall marked this pull request as ready for review October 23, 2023 18:04
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023
@auto-submit auto-submit bot merged commit 2faf992 into flutter:main Oct 23, 2023
70 checks passed
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Oct 24, 2023
* main: (139 commits)
  Change firebase device tests from Android api 30 to 33 (flutter#5185)
  [url_launcher] Add an `inAppBrowserView` mode (flutter#5205)
  [ci] Remove device_type property from Windows Arm64 properties (flutter#5193)
  [url_launcher_web] Disallows launching "javascript:" URLs. (flutter#5180)
  [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in /packages/local_auth/local_auth_android/android (flutter#4600)
  Roll Flutter from 823e083 to 5e8b5f4 (13 revisions) (flutter#5208)
  [tool] Add optional swift-format support (flutter#5204)
  [camera] CameraPlatform.createCameraWithSettings (flutter#3615)
  Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter#5201)
  Roll Flutter from 6f4850d to 823e083 (3 revisions) (flutter#5198)
  Bump actions/checkout from 4.1.0 to 4.1.1 (flutter#5167)
  Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (flutter#5196)
  [ios_platform_images]  migrate objC to swift (flutter#4847)
  [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter#5149)
  [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5150)
  [quick_actions] convert to pigeon (flutter#5159)
  [ci] Add build-only Windows Arm64 tests (flutter#5142)
  Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter#5186)
  Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter#5192)
  [ci] Finalize migration to x64 specific Windows platform (flutter#5174)
  ...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 24, 2023
flutter/packages@4bf5114...2faf992

2023-10-23 34871572+gmackall@users.noreply.github.com Change firebase device tests from Android api 30 to 33 (flutter/packages#5185)
2023-10-23 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5205)
2023-10-23 737941+loic-sharma@users.noreply.github.com [ci] Remove device_type property from Windows Arm64 properties (flutter/packages#5193)
2023-10-23 ditman@gmail.com [url_launcher_web] Disallows launching "javascript:" URLs. (flutter/packages#5180)
2023-10-23 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#4600)
2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter from 823e083 to 5e8b5f4 (13 revisions) (flutter/packages#5208)
2023-10-23 stuartmorgan@google.com [tool] Add optional swift-format support (flutter/packages#5204)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
Changes firebase device tests to use android 13. I know there is consideration [for turning them off](flutter/flutter#131429), but as long as we are running them we may as well run them on as new an android version as we can (I'm assuming here we can't use android 14 due to the [ongoing work](flutter#4974) to fix some tests on android 14).

The particular device is listed as high capacity. The list can be seen here in the 3rd option without any login https://firebase.google.com/docs/test-lab/android/available-testing-devices
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants