This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Include Android SDK 27 in the docker image and accept licenses #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - feel free to land if iOS decides it doesn't hate us anymore. |
amirh
changed the title
|
@dnfield can you make sure that the updated PR description and title makes sense? |
amirh
changed the title
|
Sounds good! |
|
I rekicked the IPA build - it looks like a flake to me. |
|
Ah nevermind. I missed a bunch of errors in there that are definitely not flakes. |
|
Landing on red, as there are currently 2 separate causes for the CI failure, this issue, and the firebase_ml_vision ios failure. Landing this fixes one issue. |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…er#1104) This was ripped off flutter#1091. CI was failing on multiple packages when trying to build apks with: ``` A problem occurred evaluating root project 'android'. > A problem occurred configuring project ':app'. > Failed to install the following Android SDK packages as some licences have not been accepted. platforms;android-27 Android SDK Platform 27 To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager. Alternatively, to transfer the license agreements from one workstation to another, see http://d.android.com/r/studio-ui/export-licenses.html Using Android SDK: /opt/android-sdk-linux ``` This tweaks the docker file to also install Android SDK 27 accept licenses for it, which fixes the CI failure. The patch was authored by @dnfield I just split part of it out of flutter#1091.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
flutter#1104)" This reverts commit 8c2b0e0.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…er#1104) This was ripped off flutter#1091. CI was failing on multiple packages when trying to build apks with: ``` A problem occurred evaluating root project 'android'. > A problem occurred configuring project ':app'. > Failed to install the following Android SDK packages as some licences have not been accepted. platforms;android-27 Android SDK Platform 27 To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager. Alternatively, to transfer the license agreements from one workstation to another, see http://d.android.com/r/studio-ui/export-licenses.html Using Android SDK: /opt/android-sdk-linux ``` This tweaks the docker file to also install Android SDK 27 accept licenses for it, which fixes the CI failure. The patch was authored by @dnfield I just split part of it out of flutter#1091.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was ripped off #1091.
CI was failing on multiple packages when trying to build apks with:
This tweaks the docker file to also install Android SDK 27 accept licenses for it, which fixes the CI failure.
The patch was authored by @dnfield I just split part of it out of #1091.