Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] Add updatePhoneNumber function #1158

Merged
merged 19 commits into from
May 14, 2019

Conversation

zerefati
Copy link
Contributor

@zerefati zerefati commented Feb 5, 2019

Add updatePhoneNumber function.

Add updatePhoneNumber function
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@zerefati
Copy link
Contributor Author

zerefati commented Feb 5, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 5, 2019
@zerefati zerefati changed the title Update firebase_user.dart Add updatePhoneNumber function Feb 5, 2019
@bparrishMines bparrishMines changed the title Add updatePhoneNumber function [firebase_auth] Add updatePhoneNumber function Feb 22, 2019
@kroikie
Copy link
Contributor

kroikie commented Mar 25, 2019

@zerefati Thanks for the contribution, we would need to have the Android and iOS implementation of this before we can merge, any chance you can add that?

@kroikie kroikie self-assigned this Mar 25, 2019
@kroikie kroikie added the WIP label Mar 27, 2019
@collinjackson
Copy link
Contributor

@zerefati - friendly ping, please let us know if you want to finish or abandon this PR

@zerefati
Copy link
Contributor Author

Yes sure, I will update it soon.

@GianlucaCesari
Copy link
Contributor

Is this going to be in the next package release?

@collinjackson
Copy link
Contributor

I am hoping to land and publish it soon, but it needs a unit test still. If anyone wants to write that one, it will help me merge the PR faster.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@GianlucaCesari
Copy link
Contributor

I'm ok with my commits being contributed to this project.

@collinjackson
Copy link
Contributor

This change LGTM, just waiting for the tests to pass.

@GianlucaCesari
Copy link
Contributor

Hey guys, what's missing to approve this PR?

@collinjackson collinjackson merged commit 0625696 into flutter:master May 14, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants