-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_auth] Add updatePhoneNumber function #1158
Conversation
Add updatePhoneNumber function
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
updated format
Update format
Update format
Updated format
updated format.
@zerefati Thanks for the contribution, we would need to have the Android and iOS implementation of this before we can merge, any chance you can add that? |
@zerefati - friendly ping, please let us know if you want to finish or abandon this PR |
Yes sure, I will update it soon. |
Is this going to be in the next package release? |
I am hoping to land and publish it soon, but it needs a unit test still. If anyone wants to write that one, it will help me merge the PR faster. |
- added test for updatePhoneNumberCredentials
feature(Tests):
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
I'm ok with my commits being contributed to this project. |
This change LGTM, just waiting for the tests to pass. |
Hey guys, what's missing to approve this PR? |
Add updatePhoneNumber function
Add updatePhoneNumber function.