This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_dynamic_links] sometimes got error NSPOSIXErrorDomain Code=53 in ios #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
added
bugfix
submit queue
|
I don't think our current |
collinjackson
approved these changes
Mar 22, 2019
ko2ic
force-pushed
the
dynamiclink_sometime_nil
branch
from
5f0518b to
a9c8f72
Compare
As in link there is a case of nil at completion of handleUniversalLink. firebase/firebase-ios-sdk#2303 Also, even if make this correction, cause an error, so fixed it to tell it to the dart side.
ko2ic
force-pushed
the
dynamiclink_sometime_nil
branch
2 times, most recently
from
aa687ca to
0db4f75
Compare
|
It became all green. Could you merge? |
|
Yea I can merge it for you. I added a version bump and a corresponding part to the android side. Thanks for the contribution! I'll merge once it goes green again. |
gspencergoog
pushed a commit
to gspencergoog/plugins
that referenced
this pull request
Mar 27, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in link, there is a case of nil at the completion of handleUniversalLink.
firebase/firebase-ios-sdk#2303
Also, even if sleep, cause an error, so fixed it to tell
it to the dart side.
flutter/flutter#27810