Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Flutterfire apps no longer show a confusing log message about configuring default app #1192

Merged
merged 19 commits into from
Feb 21, 2019
Merged

Flutterfire apps no longer show a confusing log message about configuring default app #1192

merged 19 commits into from
Feb 21, 2019

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Feb 11, 2019 •
edited
Loading

Fixes flutter/flutter#16534

Note that this doesn't completely fix the issue, it just changes the error message from the previous, really confusing:

"4.8.1 - [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured.
Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application
initialization.

New log message:

[Firebase/Core][I-COR000004] App with name __FIRAPP_DEFAULT does not exist.

@collinjackson collinjackson mentioned this pull request Feb 13, 2019
Closed
cyanglaz
cyanglaz reviewed Feb 13, 2019
View reviewed changes
packages/cloud_firestore/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no public api change, the version should only be updated as a patch, so 0.9.0+2
https://www.dartlang.org/tools/pub/versioning#semantic-versions
Same for everything related in this PR.
@collinjackson @mklim can you confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is more of a bugfix and should just be bumping the patch numbers everywhere. Sometimes it is appropriate to increment the minor version just based on the behavior of private code but I don't think this change really fits that edge case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with doing this as 0.9.0+2

@collinjackson
Copy link
Contributor Author

I switched to using patch versions, will land this once the bots are happy

@Hixie
Copy link
Contributor

Hixie commented Feb 13, 2019

test?

bparrishMines
bparrishMines reviewed Feb 14, 2019
View reviewed changes
packages/cloud_firestore/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.9.0+2
Copy link
Contributor

@bparrishMines bparrishMines Feb 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the pubspec.yaml need the version bump too?

packages/firebase_dynamic_links/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.2.0+2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pubspec.yaml version

packages/firebase_performance/pubspec.yaml Outdated
@@ -4,7 +4,8 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_performance
version: 0.1.0+2
version: 0.1.0+3
>>>>>>> 4f024c7404c01e1f3b55be61704d2deb53f6ca41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge line

@collinjackson
Copy link
Contributor Author

test?

I don't think that our current infrastructure can test this change, because the only observable impact is in the iOS device logs.

@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
ed707fc 
…ultapp
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
d52068d 
…ultapp
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
b580677 
…ultapp
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
63a4607 
…ultapp
@collinjackson
Bump a version
0e3ed9b
@collinjackson
Remove merge marker
d961d33
@collinjackson
Fix merge CHANGELOG
f986464
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
0e55eb2 
…ultapp
@collinjackson
Add more logs
e83c2d1
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
5b2ce40 
…ultapp
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
fd28bac 
…ultapp
@collinjackson
Adding missing log to admob
731bfa0
@collinjackson
Fix changelog
d8eb054
@collinjackson
Merge branch 'master' of github.com:flutter/plugins into bugpile_defa…
bf60b5e 
…ultapp
@collinjackson collinjackson merged commit 7e22fb8 into flutter:master Feb 21, 2019
@collinjackson collinjackson deleted the bugpile_defaultapp branch February 21, 2019 21:46
idealopamp pushed a commit to idealopamp/plugins that referenced this pull request Feb 21, 2019
@collinjackson @idealopamp
Flutterfire apps no longer show a confusing log message about configu…
788b415 
…ring default app (flutter#1192)
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@collinjackson
Flutterfire apps no longer show a confusing log message about configu…
244b454 
…ring default app (flutter#1192)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kroikie kroikie Awaiting requested review from kroikie

@amirh amirh Awaiting requested review from amirh

4 more reviewers

@cyanglaz cyanglaz cyanglaz left review comments

@mklim mklim mklim left review comments

@bparrishMines bparrishMines bparrishMines left review comments

@diver2 diver2 diver2 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove spurious "default app not configured" warning from Flutterfire iOS logs
7 participants
@collinjackson @Hixie @cyanglaz @mklim @bparrishMines @diver2 @googlebot