[in_app_purchase] make payment objc #1231

cyanglaz · 2019-02-15T21:17:21Z

The objective-c portion of add payment flow.

Since there is no dart code in this PR, it could be hard to trace what is going on. Included 2 purchase flows below to better explain.

A regular flow of a user to process a purchase will be as such:

User queries the products by -[InAppPurchasePlugin startProductRequest:result:]
User creates a payment object using productID which is found in the result of the 1st step.
User make a payment calling -[InAppPurchasePlugin addPayment:result:] using the payment object gotten from step 2.
updatedTransaction in dart waiting for the transaction to be at state of 'purchased'
User finish the transaction by calling -[InAppPurchasePlugin finishTransaction:result:] with the transaction gotten from step 4.

A app store purchase flow will be as such:

Customer triggered the purchase in the app store.
Programmer gets a notification in a callback named shouldAddStorePayment in dart.
If shouldAddStorePayment return true, the payment object will be automatically added to the queue using -[InAppPurchasePlugin addPayment:result:] (called by our plugin code, not the programmer)
Same as step 4 in the regular flow from this point.

flutter/flutter#26328

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

mklim · 2019-02-19T22:03:51Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

+  SKPayment *payment = [self.paymentsCache objectForKey:productID];
+  // User can use  payment object with mutable = true and add simulatesAskToBuyInSandBox = true to
+  // test the payment flow.
+  if (!payment || [paymentMap[@"mutable"] boolValue] == YES) {


This ends up creating a mutable payment whenever payment isn't specified, not just when mutable is explicitly specified as an option. Is that something we want to do?

The mutable keyword is indeed confusing. I created this for user to test the payment in sandbox, I have updated the mutable keyword to usePaymentObject in a different branch. Do you think changing the keyboard to usePaymentObject makes more sense here?

Yeah, I think that makes sense.

I'm still a little confused over the code silently creating an SkMutable payment object whenever it can't find a pre-existing payment in the map. Do we want to default to that or would it make sense to error if we can't find an existing payment instead?

Oh you are right. Going to update. I am also going to re arrange the code a bit to make it more readable.

mklim · 2019-02-19T22:08:38Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

+    SKMutablePayment *mutablePayment = [[SKMutablePayment alloc] init];
+    mutablePayment.productIdentifier = productID;
+    NSNumber *quantity = [paymentMap objectForKey:@"quantity"];
+    if (quantity) {


Should we panic and bail here if we don't have a quantity?

I think we should update the quantity to default to 1 here, ill update.

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

mklim · 2019-02-19T22:36:37Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

+  for (SKPaymentTransaction *transcation in transactions) {
+    [maps addObject:[FIAObjectTranslator getMapFromSKPaymentTransaction:transcation]];
+  }
+  [self.callbackChannel invokeMethod:@"updatedTransaction" arguments:maps];


nit: I think it would be a little clearer to name these methods "Transactions" here and below, since there's multiple transactions in each method.

mklim · 2019-02-19T22:36:59Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

+
+- (void)handleTransactionsRemoved:(NSArray<SKPaymentTransaction *> *)transactions {
+  NSMutableArray *maps = [NSMutableArray new];
+  for (SKPaymentTransaction *transcation in transactions) {


nit: s/transcation/transaction/g

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

googlebot · 2019-02-19T22:51:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers can find more info about SignCLA and this PR by following this link.

googlebot · 2019-02-19T22:51:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers can find more info about SignCLA and this PR by following this link.

googlebot · 2019-02-20T01:20:15Z

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

cyanglaz · 2019-02-20T01:25:49Z

Mistakenly sent out a bunch of review requests due to the file owners setting. Please ignore the requests.

mklim

LGTM

mklim · 2019-02-20T20:47:25Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

+  // the product to process the payment.
+  SKProduct *product = [self.productsCache objectForKey:productID];
+  if (product) {
+    payment = [SKPayment paymentWithProduct:product];


Can users set quantity this way?

It is not supported with the regular purchase flow, user will need to use the custom payment object.

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

googlebot · 2019-02-20T22:53:24Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers can find more info about SignCLA and this PR by following this link.

googlebot · 2019-02-20T23:39:16Z

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

Chris Yang added 9 commits February 15, 2019 10:20

draft

3d21006

second draft

73caea7

finish transaction

9420db0

adding more comments

62a9974

more comments

2ec9c58

let dart intercept the payment from store

e75411a

create payment method

824eee8

rearrange method order

98f8d03

formatting

e1176e5

cyanglaz requested a review from mklim February 15, 2019 21:17

googlebot added the cla: yes label Feb 15, 2019

Chris Yang added 3 commits February 19, 2019 13:34

typo fix

ab75985

remove unused code

564d13b

update to weakself

b11e3c5

mklim reviewed Feb 19, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels Feb 19, 2019

cyanglaz requested review from amirh, bparrishMines, collinjackson, kroikie and mehmetf as code owners February 20, 2019 00:48

cyanglaz force-pushed the iap_make_payment_objc branch from 71e0a40 to 253f67a Compare February 20, 2019 00:53

cyanglaz removed request for collinjackson, amirh, bparrishMines, kroikie and mehmetf February 20, 2019 00:53

cyanglaz requested review from collinjackson and removed request for collinjackson February 20, 2019 00:54

cyanglaz force-pushed the iap_make_payment_objc branch from 543862d to 253f67a Compare February 20, 2019 01:04

review fixes

7f9e5a9

cyanglaz force-pushed the iap_make_payment_objc branch from c8b670c to 7f9e5a9 Compare February 20, 2019 01:20

googlebot added cla: yes and removed cla: no labels Feb 20, 2019

Chris Yang added 4 commits February 19, 2019 17:26

formatting

0187f9a

rearrange payment object handling code

b756e70

fix unit test, remove nil check for callback blocks

4dd5b14

formatting

f3cdb83

mklim approved these changes Feb 20, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels Feb 20, 2019

cyanglaz force-pushed the iap_make_payment_objc branch from ceb3960 to f3cdb83 Compare February 20, 2019 23:39

googlebot added cla: yes and removed cla: no labels Feb 20, 2019

review fixes

aec3ede

cyanglaz merged commit f92ba3a into flutter:master Feb 21, 2019

cyanglaz deleted the iap_make_payment_objc branch February 21, 2019 07:45

idealopamp pushed a commit to idealopamp/plugins that referenced this pull request Feb 21, 2019

IAP make payment objc (flutter#1231)

d3ac363

cyanglaz changed the title ~~Iap make payment objc~~ [in_app_purchase] make payment objc Feb 22, 2019

[in_app_purchase] make payment objc #1231

[in_app_purchase] make payment objc #1231

Uh oh!

Conversation

cyanglaz commented Feb 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

googlebot commented Feb 19, 2019

Uh oh!

googlebot commented Feb 19, 2019

Uh oh!

googlebot commented Feb 20, 2019

Uh oh!

cyanglaz commented Feb 20, 2019

Uh oh!

mklim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Feb 20, 2019

Uh oh!

googlebot commented Feb 20, 2019

Uh oh!

Uh oh!

cyanglaz commented Feb 15, 2019 •

edited

Loading