This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] copying list for prevent mutate from outside #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
collinjackson
approved these changes
Jul 15, 2019
| @@ -127,7 +128,7 @@ class SharedPreferences { | |||
| .invokeMethod('remove', params) | |||
| .then<bool>((dynamic result) => result); | |||
| } else { | |||
| _preferenceCache[key] = value; | |||
| _putToCache(key, value); | |||
There was a problem hiding this comment.
Since this is only used in one place, I don't think we need to split it out into its own method.
fix reference to version
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…utter#1276) * copying list for prevent mutate from outside
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed flutter/flutter#28015