This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_firestore] ios check for nil snapshot in cloud_firestore error handling instead of checking for non-nil error #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecking for non-nil error
collinjackson
changed the title
collinjackson
changed the title
collinjackson
changed the title
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…handling instead of checking for non-nil error (flutter#1339) * Check for nil snapshot in cloud_firestore error handling instead of checking for non-nil error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#15837
iOS only
In addition to making our iOS plugin usage of the API match the docs, this also fixes a case where we were returning from method call twice in an error case.
on Android we check if the error is not null per the example code.