Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_admob] Update documentation to add iOS Admob ID & add iOS Admob ID in example project #1377

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

KaYBlitZ
Copy link
Contributor

@KaYBlitZ KaYBlitZ commented Mar 21, 2019

Description

Update documentation to add app id in Info.plist. It is required starting in version 7.42.0. See https://firebase.google.com/docs/admob/ios/quick-start#update_your_infoplist.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contribution Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin user to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@KaYBlitZ KaYBlitZ requested a review from amirh as a code owner March 21, 2019 19:25
@collinjackson
Copy link
Contributor

This is a documentation-only change, but we still need to update the CHANGELOG.md and pubspec.yaml. Could you please update your CL to bump 0.8.0+3 to 0.8.0+4?

@KaYBlitZ KaYBlitZ changed the title [firebase_admob] Update documentation to add app id in Info.plist [firebase_admob] Update documentation to add iOS Admob ID & add iOS Admob ID in example project Mar 22, 2019
@KaYBlitZ
Copy link
Contributor Author

Hey, I updated the CHANGELOG and pubspec to +4. I also decided to add the iOS Admob App ID to the Info.plist in the example project so it won't crash on startup.

@jeffscaturro-aka
Copy link

I was just poking around seeing if we needed to throw up a PR to add this as well. Error isn't easily seen from running via flutter; we saw the actual error causing the crash when we ran through Xcode.

Anything we can do to help get this through?

@collinjackson collinjackson merged commit 405670e into flutter:master Apr 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants