Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[cloud_firestore] Add metadata field to DocumentSnapshot #1387

Merged
merged 10 commits into from Apr 2, 2019

Conversation

tsuba3
Copy link
Contributor

@tsuba3 tsuba3 commented Mar 23, 2019

Description

Add SnapshotMetadata to DocumentSnapshot. SnapshotMetadata has two boolean field hasPendingWrites and isFromCache. This PR enables to know snapshot is from server or local cache.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@@ -3,7 +3,7 @@ description: Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database
live synchronization and offline support on Android and iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/cloud_firestore
version: 0.9.7+2
version: 0.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be 0.9.8, as a non-breaking API addition

@collinjackson collinjackson merged commit 01bce6a into flutter:master Apr 2, 2019
[experimental] Plugins PR tracking automation moved this from Awaiting initial triage to Done Apr 2, 2019
@tsuba3 tsuba3 deleted the cloud-firestore-metadata branch April 3, 2019 07:27
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
4 participants