Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_crashlytics] Do not break debug log formatting. #1427

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

ened
Copy link
Contributor

@ened ened commented Apr 2, 2019

Description

firebase_crashlytics should keep debug traces readable in debug mode.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • [] I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines changed the title Do not break debug log formatting. [firebase_crashlytics] Do not break debug log formatting. Apr 2, 2019
@ened
Copy link
Contributor Author

ened commented Apr 3, 2019

This PR is incomplete I think. The debug logs are still severely hurt when the crashlytics plugin is activated. Need to re-check.

@collinjackson collinjackson requested a review from kroikie April 4, 2019 17:17
@kroikie
Copy link
Contributor

kroikie commented Apr 8, 2019

@ened Could you give more context around what you expect and what you are seeing?

@kroikie kroikie self-assigned this Apr 8, 2019
@ened
Copy link
Contributor Author

ened commented Apr 11, 2019

When the plugin is installed, but not activated (in debugging), I expect the exception traces to be in 100% same format as before installing the plugin. Currently, the traces are garbled / unreadable. I tried fixing that but had to stop due to a lack of time.

@kroikie kroikie force-pushed the crashlytics-formatting branch from 40e32b5 to 13d7b2b Compare April 15, 2019 18:18
@kroikie kroikie merged commit 1ca83b0 into flutter:master Apr 15, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants