This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_firestore] Remove usage of invokeMapMethod
#1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Apr 3, 2019
| @@ -1,3 +1,7 @@ | |||
| ## 0.9.8+1 | |||
There was a problem hiding this comment.
I think it would be 0.9.9 rather than 0.9.8+1 since a behavior change is evident
collinjackson
approved these changes
Apr 3, 2019
|
lgtm once bots are happy |
added 2 commits
April 2, 2019 17:17
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
`invokeMapMethod` and `invokeListMethod` currently crashes if the return value from methodChannel is null. Remove usages of these 2 methods to prevent crashes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invokeMapMethodandinvokeListMethodcurrently crashes if the return value from methodChannel is null. Remove usages of these 2 methods to prevent crashes.