Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] AuthCredential for email and link #1458

Merged
merged 12 commits into from Apr 8, 2019
Merged

[firebase_auth] AuthCredential for email and link #1458

merged 12 commits into from Apr 8, 2019

Conversation

creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Apr 6, 2019

Description

@collinjackson I decided that the credential would make more sense (#1450 ).
They would work in parallel, however, I feel like it would be quite redundant to include both.

Related Issues

This pull request would solve flutter/flutter#22958 in a way that is more coherent to the rest of the plugin than #1159 does and also enable linking and reauthenticating.

Checklist

  • All Cirrus CI checks are passing. The ones failing are unrelated to this pull request.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- I'm waiting for the tree to be green so I can land it.

It would be great to have an integration test for this feature, but I'm not sure yet about the best way to do it.

@collinjackson collinjackson merged commit 5f385af into flutter:master Apr 8, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants