-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[google_maps_flutter] Add a bitmap descriptor that is aware of scale #1478
[google_maps_flutter] Add a bitmap descriptor that is aware of scale #1478
Conversation
We do not need to scale images in android because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good (Just some nits), but I feel like [BitmapDescriptor] can totally be a separate plugin so people can use it for anything not just google map. @amirh @collinjackson
packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m
Outdated
Show resolved
Hide resolved
…ller.m Co-Authored-By: iskakaushik <iska.kaushik@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@cyanglaz what use case were you thinking of? Also, we can always factor it out to a different plugin if need be. For now, google maps is the only consumer of it, so might as well leave it here. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not able to get the Size param to do anything when creating an ImageConfiguration, or modifying the default one shown in the example. On Android my 64x64 marker is still really small. On both platforms modifying Size does nothing. Is there something I'm missing? |
Description
This makes it so you can create BitmapDescriptors that are aware of screen dpi
Related Issues
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?