Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Add a bitmap descriptor that is aware of scale #1478

Merged
merged 6 commits into from
Apr 11, 2019
Merged

[google_maps_flutter] Add a bitmap descriptor that is aware of scale #1478

merged 6 commits into from
Apr 11, 2019

Conversation

iskakaushik
Copy link
Contributor

Description

This makes it so you can create BitmapDescriptors that are aware of screen dpi

Related Issues

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@iskakaushik iskakaushik requested a review from amirh as a code owner April 10, 2019 23:47
@iskakaushik
Copy link
Contributor Author

We do not need to scale images in android because Bitmap doesn't scale images by default

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good (Just some nits), but I feel like [BitmapDescriptor] can totally be a separate plugin so people can use it for anything not just google map. @amirh @collinjackson

…ller.m

Co-Authored-By: iskakaushik <iska.kaushik@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@iskakaushik
Copy link
Contributor Author

@cyanglaz what use case were you thinking of?

Also, we can always factor it out to a different plugin if need be. For now, google maps is the only consumer of it, so might as well leave it here.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik merged commit 4069817 into flutter:master Apr 11, 2019
@iskakaushik iskakaushik deleted the fix-markers-issues-once branch April 11, 2019 17:33
@JRR-OSU
Copy link

JRR-OSU commented Apr 21, 2019

@iskakaushik

I am not able to get the Size param to do anything when creating an ImageConfiguration, or modifying the default one shown in the example. On Android my 64x64 marker is still really small. On both platforms modifying Size does nothing. Is there something I'm missing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants