This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Fix unused vars and rename #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
reviewed
Apr 11, 2019
| @@ -154,6 +154,13 @@ static Object latlngBoundsToJson(CameraPosition position) { | |||
| return data; | |||
| } | |||
|
|
|||
| static Object latlngBoundsToJson(LatLngBounds latLngBounds) { | |||
There was a problem hiding this comment.
The return type can be Map<String, Object> arguments
There was a problem hiding this comment.
I was being consistent with all the other return methods in this class. These are in most cases passed on to the dart side and not really used for their return nature, so left them as those. Ideally, I agree that we would use the most specific return type, but in this case I don't think it matters as much.
cyanglaz
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.