Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

BitmapDescriptor#fromBytes should be consistent across platforms #1489

Merged
merged 1 commit into from
Apr 13, 2019
Merged

BitmapDescriptor#fromBytes should be consistent across platforms #1489

merged 1 commit into from
Apr 13, 2019

Conversation

iskakaushik
Copy link
Contributor

  • Android Bitmaps scale images to account for dpi.
  • iOS UIImages do not, we need to account for that.

- Android Bitmaps scale images to account for dpi.
- iOS UIImages do not, we need to account for that.
@iskakaushik iskakaushik requested a review from amirh as a code owner April 12, 2019 19:46
@iskakaushik iskakaushik requested a review from cyanglaz April 12, 2019 19:46
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik merged commit 9a41270 into flutter:master Apr 13, 2019
@ened
Copy link
Contributor

ened commented Apr 29, 2019

@cyanglaz @iskakaushik please publish on pub on every release..

@iskakaushik
Copy link
Contributor Author

@ened sorry about that, just published. Will try to make it a part of our CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants