Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_analytics] Initial integration test #1492

Merged
merged 4 commits into from
Apr 18, 2019

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Apr 14, 2019

Description

Starting point for integration testing. I don't know how to check the results yet, so just making sure that exceptions aren't thrown.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson collinjackson requested a review from kroikie as a code owner April 14, 2019 20:07
@collinjackson collinjackson changed the title Initial integration test for firebase_analytics [firebase_analytics] Initial integration test Apr 14, 2019
@collinjackson collinjackson requested a review from cyanglaz April 15, 2019 17:08
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some personal opinions on using expect(..., completes) so that we would know how many test cases there are.

@collinjackson collinjackson merged commit d3c96e9 into flutter:master Apr 18, 2019
@collinjackson collinjackson deleted the analytics_test branch April 18, 2019 21:23
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Initial integration test for firebase_analytics
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants