Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] Fixes lint error by using getApplicationContext() #1502

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

josh-burton
Copy link
Contributor

Description

When running Android Lint on a project using the connectivity plugin, Lint gives the following error:

The WIFI_SERVICE must be looked up on the Application context or memory will leak on devices < Android N. Try changing registrar.context() to registrar.context().getApplicationContext()

This applies the suggested change.

Related Issues

flutter/flutter#28928

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

When running Android Lint on a project using the connectivity plugin, Lint gives the following error:

`The WIFI_SERVICE must be looked up on the Application context or memory will leak on devices < Android N. Try changing registrar.context() to registrar.context().getApplicationContext()`

This applies the suggested change.
@collinjackson
Copy link
Contributor

Looks good. Since the Dart API didn't change and plugin is pre-1.0, I'm making this a +1 change.

@collinjackson collinjackson merged commit c928a0e into flutter:master Apr 19, 2019
@josh-burton josh-burton deleted the connectivity-lint-check branch April 19, 2019 02:02
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* WIP on migrating firebase_auth

* More WIP on migration

* WIP on migration

* update test

* Fix analyzer errors

* Use older version of package:async

* Widen version range for platform interface dependency

* Only export AuthCredential

* Fix analyzer error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants