This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Test: wait for page to load before checking the content #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2019 12:40
| @@ -70,6 +71,11 @@ void main() { | |||
| controllerCompleter.complete(controller); | |||
| }, | |||
| javascriptMode: JavascriptMode.unrestricted, | |||
| onPageFinished: (String url) { | |||
| if (url.contains('flutter-header-echo')) { | |||
| headerEchoCompleter.complete(url); | |||
There was a problem hiding this comment.
Maybe we should make it a streamcontroller instead of a completer
|
Let's remove the skip from the test and release as a new version if the bots are happy |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#31510 seems to exist. Using it to make the header loading test not flake