This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Support Color's alpha channel when converting to UIColor on iOS #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Apr 29, 2019
| return [UIColor colorWithRed:((float)((value & 0xFF0000) >> 16)) / 255.0 | ||
| green:((float)((value & 0xFF00) >> 8)) / 255.0 | ||
| blue:((float)(value & 0xFF)) / 255.0 | ||
| alpha:1.0]; | ||
| alpha:((float)((value & 0xFF000000) >> 24)) / 255.0]; |
There was a problem hiding this comment.
How does this change affect people who are already using some color. Since it's signed i'm guessing value & 0xFF000000 will default to FF which should still retain the existing semantics of alpha being 1.0. Could you confirm that behavior for me?
There was a problem hiding this comment.
Yes, it will retain the existing semantics. The alpha channel already works on Android, so users are presumably already using Colors with the alpha channel set to FF, and this will just evaluate to alpha: 1.0.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…tter#1549) * Added Apple auth provider Co-Authored-By: Collin Jackson <jackson@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Color's alpha channel when converting to UIColor on iOS. This allows polylines and other overlays to be added in the future (e.g. circles and polygons) to be translucent, to match the behavior on Android.
Tested manually using a translucent polyline in the iOS simulator.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?