This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Fix player initialization and other warnings #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When a player has not initialized it's presentationSize is returned as CGSizeZero. 2. The enum type must be AVPlayerItemStatusFailed not AVPlayerStatusFailed 3. Fix a few other IDE warnings.
This was referenced Apr 29, 2019
WoodyGuo
pushed a commit
to liuwei1130/plugins
that referenced
this pull request
Jun 27, 2019
…1552) * [video_player] Fix player initialization and other warnings 1. When a player has not initialized it's presentationSize is returned as CGSizeZero. 2. The enum type must be AVPlayerItemStatusFailed not AVPlayerStatusFailed 3. Fix a few other IDE warnings. * update pubspec and changelog
|
Hi @iskakaushik @cyanglaz , We are using the video_player to play mp3 files (since there is no well maintained audio plugin). It was working perfectly but since the file have a width and height of 0 this |
|
I'm using this video_player to play mp3 files as @quentinleguennec . Now it breaks my app. Please help with this issue. Thanks. |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Update README to mention web support
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player has not initialized it's presentationSize is
returned as CGSizeZero.
The enum type must be AVPlayerItemStatusFailed not AVPlayerStatusFailed
Fix a few other IDE warnings.
Related Issues
Fixes flutter/flutter#19197