Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 1, 2019

Description

Reformat firebase_performance plugin to enable the use of meaningful integration testing.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines changed the title Perf combine [firebase_performance] [WIP] Testing of firebase performance reformat PRs May 1, 2019
@collinjackson collinjackson changed the title [firebase_performance] [WIP] Testing of firebase performance reformat PRs [firebase_performance] [WIP] Testing of firebase performance rewrite PRs May 8, 2019
@bparrishMines bparrishMines changed the title [firebase_performance] [WIP] Testing of firebase performance rewrite PRs [firebase_performance] Testing of firebase performance rewrite PRs May 14, 2019
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM. Minor nit though, I think that assigning test data to variables in unit tests is discouraged and that we're encouraging less code re-use in favor of making the tests more declarative. For example, instead of assigning value to 'apple' you could say 'apple' everywhere.

@amirh may have more opinions about this. I realize this guideline is a bit unintuitive and I don't feel strongly about it, probably we should write it down either way.

@bparrishMines
Copy link
Contributor Author

I was thinking about this as well. I typically always use literals, but I wanted to make this PR a little shorter and be focused on the refactor while the next one will be focused on tests.

@bparrishMines bparrishMines merged commit 90ed52d into flutter:master May 14, 2019
@bparrishMines bparrishMines deleted the perf_combine branch May 14, 2019 20:13
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants