Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[sensors] Change Android implementation to use SENSOR_DELAY_GAME, … #1563

Closed
wants to merge 2 commits into from

Conversation

mikeryder
Copy link

…which is approximately 50Hz. For reference the iPhone implementation is still sending updates faster at 100Hz.

Update Gravity constant to be more precise.

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

*flutter/flutter#25971 - This PR does not fix the issue entirely because the issue is requesting parameters for the frequency of sensor updates, but at least brings the refresh rates of iOS and Android closer until the larger PR with parameters is accepted. *

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

mikeryder added 2 commits May 2, 2019 16:34
…ch is approximately 50Hz. For reference the iPhone implementation is still sending updates faster at 100Hz.

Update Gravity constant to be more precise.
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! However, we’re currently not accepting non-critical PRs for this plugin, as we hope in time to be able to transition users to the corresponding plugin in the Flutter Community Plus Plugins repository. We encourage you to submit your PR there.

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

@stuartmorgan-g stuartmorgan-g added the plus-transition PR closed due to the goal of transitioning to Flutter Community Plus Plugins label Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: sensors plus-transition PR closed due to the goal of transitioning to Flutter Community Plus Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants