This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Fix bug preventing video recording with audio #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
May 16, 2019
| @@ -259,6 +259,7 @@ public boolean onRequestPermissionsResult(int id, String[] permissions, int[] gr | |||
| final boolean enableAudio) { | |||
|
|
|||
| this.cameraName = cameraName; | |||
| this.enableAudio = enableAudio; | |||
There was a problem hiding this comment.
I realized that this variable was never set in PR: #837
I hadn't realized a null boolean defaults to false in in java if statements.
There was a problem hiding this comment.
I hadn't realized a
nullbooleandefaults to false in in java if statements.
Yeah, there's a bunch of weird potential behavior around this. My favorite is that Boolean is a class and therefore nullable. But boolean is a primitive type and cannot be null. So it's totally possible to get an NPE casting a Boolean to a boolean.
This is also true for Integer and int.
bparrishMines
commented
May 16, 2019
| @@ -443,17 +444,16 @@ private void prepareMediaRecorder(String outputFilePath) throws IOException { | |||
| mediaRecorder.release(); | |||
| } | |||
| mediaRecorder = new MediaRecorder(); | |||
|
|
|||
| if (enableAudio) mediaRecorder.setAudioSource(MediaRecorder.AudioSource.MIC); | |||
There was a problem hiding this comment.
The settings for MediaRecorder have to be called in a specific order.
bparrishMines
changed the title
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug preventing video recording
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?