This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Change LocalAuth to use Biometric API #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiajiabingcheng Please take a look at this as well. It would be good if you copied this to Leafy's codebase and gave it a try. |
mklim
approved these changes
May 22, 2019
...ages/local_auth/android/src/main/java/io/flutter/plugins/localauth/AuthenticationHelper.java
Outdated
Show resolved
Hide resolved
|
It seems that we have to change the Activity class manually, shouldn't this be mentioned on the readme? |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the LocalAuth plugin on Android to Biometric API for showing the fingerprint dialog. This will allow us to implement more biometric authentication schemes (and others such as PIN) in the future.
Related Issues
flutter/flutter#18690
Breaking Change
This is a breaking change because it requires Flutter applications on Android to extend a FragmentActivity rather than a regular Activity. The fix is to use
FlutterFragmentActivityinstead ofFlutterActivity. The y version has been bumped due to this.