Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 22, 2019

Description

Certain classes/types in the image picker iOS implementation are not following the official naming convention described here https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingBasics.html#//apple_ref/doc/uid/20001281-1002226-BBCJECED.
(2 or 3 letters prefix before a class/type name to avoid conflicts between other frameworks)

This PR added FLT to all the Classes, Enums, Typedefs, and Constants in this plugin.

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz cyanglaz self-assigned this May 22, 2019
@cyanglaz cyanglaz changed the title [image_picker] Rename iOS objects according to the official Objective-C naming convention. [image_picker] Rename iOS class according to the official Objective-C naming convention. May 22, 2019
@collinjackson collinjackson self-requested a review May 22, 2019 22:33
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyanglaz cyanglaz merged commit f81ebcc into flutter:master May 22, 2019
@cyanglaz cyanglaz deleted the image_picker_ios_rename branch May 22, 2019 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants