Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_dynamic_links] Fix Android crashing when a headless plugin register this plugin. #1677

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

madtocc
Copy link
Contributor

@madtocc madtocc commented May 31, 2019

If there's a headless plugin it won't be able to register this plugin (there will be no activity from the registrar).

@madtocc madtocc requested a review from bparrishMines as a code owner May 31, 2019 18:10
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@madtocc madtocc changed the title Fix Android crashing when a headless plugin register this plugin. [firebase_dynamic_links] Fix Android crashing when a headless plugin register this plugin. May 31, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bparrishMines
Copy link
Contributor

Hi @madtocc,

Thanks for the contribution! I merged in master to this branch and will merge this once tests pass again.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines merged commit fcb25c6 into flutter:master Jun 20, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants