This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[package_info]Update README.md to reflect iOS issue. #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
changed the title
|
Thank you for creating this PR! Please update the description and related issue in this PR. |
|
I am sorry, but I am not sure what you are asking me to do. I believe you already prefixed the description with "[package_info]" What more needs to be done? Thanks. |
|
@pambrose No worries. So I only prefixed the title of the PR. There is a description and related issue in the PR body that you might want to fill out, so we know what is this PR about. |
|
Sorry, now I understand what you wanted. |
cyanglaz
approved these changes
Jul 8, 2019
Co-Authored-By: Chris Yang <ychris@google.com>
collinjackson
approved these changes
Jul 15, 2019
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
* Update README.md to reflect iOS issue. * Add more details to packages/package_info/README.md Co-Authored-By: Chris Yang <ychris@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to the version string in 'pubspec.yaml' are not reflected in the package_info value on iOS.
As noted here, package_info on iOS requires the Xcode build folder to be rebuilt after changes to the version string in
pubspec.yaml.This PR does not fix the problem, but warns users about the need to rebuild the Xcode build folder.
Related Issues
No related issues.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?