[firebase_core] Automate version retrieval #1733

kroikie · 2019-06-12T22:25:08Z

Description

Automate the retrieval of the plugin's version for user agent reporting to Firebase.

collinjackson

Looks good for the Android side; a few nits

collinjackson · 2019-06-12T22:28:42Z

...core/android/src/main/java/io/flutter/plugins/firebase/core/FlutterFirebaseAppRegistrar.java

@@ -8,7 +8,7 @@

 public class FlutterFirebaseAppRegistrar implements ComponentRegistrar {
  private static final String LIBRARY_NAME = "flutter-fire-core";
-  private static final String LIBRARY_VERSION = "0.4.0+3";
+  private static final String LIBRARY_VERSION = BuildConfig.FLUTTER_FIRE_VERSION;


I don't think you need to declare it here; you can just use BuildConfig.VERSION_NAME below.

collinjackson · 2019-06-12T22:29:17Z

packages/firebase_core/android/build.gradle

 android {
    compileSdkVersion 28

    defaultConfig {
        minSdkVersion 16
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+        buildConfigField "String", "FLUTTER_FIRE_VERSION", "\"${flutterFireVersion()}\""


I think I would call this VERSION_NAME; FLUTTER_FIRE is a bit non standard compared to what other SDKs are doing

Salakar · 2019-06-13T01:49:57Z

packages/firebase_core/android/build.gradle

+ * @return String representing version of the plugin.
+ */
+def flutterFireVersion() {
+    File pubspec = new File('../../pubspec.yaml')


This may be cleaner:

File pubspec = new File(project.projectDir.parentFile, 'pubspec.yaml')

project.projectDir = <pluginRoot>/android
parentFile = <pluginRoot>

Otherwise should probably use File.separator for Windows support instead of /

Salakar · 2019-06-13T01:52:10Z

...core/android/src/main/java/io/flutter/plugins/firebase/core/FlutterFirebaseAppRegistrar.java

  @Override
  public List<Component<?>> getComponents() {
    return Collections.<Component<?>>singletonList(
-        LibraryVersionComponent.create(LIBRARY_NAME, LIBRARY_VERSION));
+        LibraryVersionComponent.create(
+            "flutter-fire-core", BuildConfig.VERSION_NAME.replaceAll("\\+", "-")));


Does this replace all need to be done at runtime - can we move the logic to build time inside of the flutterFireVersion() method?

Salakar · 2019-06-13T01:55:22Z

packages/firebase_core/ios/firebase_core.podspec

@@ -18,4 +18,11 @@ A new flutter plugin project.
  s.dependency 'Firebase/Core'
  s.ios.deployment_target = '8.0'
  s.static_framework = true
+
+  s.prepare_command = <<-CMD


CocoaPods already provides the versions via an NSBundle for each podspec, as shown in my other PR - not sure if code-gen is needed if we already have the version at runtime

Salakar · 2019-06-13T01:57:53Z

packages/firebase_core/ios/firebase_core.podspec

@@ -18,4 +18,11 @@ A new flutter plugin project.
  s.dependency 'Firebase/Core'
  s.ios.deployment_target = '8.0'
  s.static_framework = true
+
+  s.prepare_command = <<-CMD
+    PUBSPEC_VERSION=`cat ../pubspec.yaml | grep version: | sed 's/version: //g'`


It's possible to read the yaml file via the default Ruby yaml library that comes with OSX

require 'yaml' pubspec = YAML.load_file(File.join('..', 'pubspec.yaml')) # ... Pod::UI.puts "This plugin version is '#{pubspec['version']}'"

ened · 2019-06-13T15:12:15Z

This PR currently breaks plugin integrations as shown in #34385.

This reverts commit 1e01c9e.

* Revert "[firebase_core] Automate version retrieval (#1733)" This reverts commit 1e01c9e. * Update versions and CHANGELOG to call this version 0.4.0+5

* Automate version retrieval

* Revert "[firebase_core] Automate version retrieval (flutter#1733)" This reverts commit 1e01c9e. * Update versions and CHANGELOG to call this version 0.4.0+5

Automate version retrieval

40c56d7

kroikie requested a review from collinjackson as a code owner June 12, 2019 22:25

googlebot added the cla: yes label Jun 12, 2019

collinjackson reviewed Jun 12, 2019

View reviewed changes

iOS implementation

604ef79

collinjackson force-pushed the auto-user-agent-version branch from 489879d to 604ef79 Compare June 12, 2019 22:47

Replace + with -

4b637db

collinjackson mentioned this pull request Jun 12, 2019

Remove hard coded version check #1735

Merged

kroikie added 2 commits June 12, 2019 16:40

Replace + with -

c46dff2

update plugin version variable name

24e5e68

kroikie mentioned this pull request Jun 13, 2019

[draft] accessing a pubspec version at runtime #1736

Closed

13 tasks

kroikie merged commit 1e01c9e into flutter:master Jun 13, 2019

Salakar reviewed Jun 13, 2019

View reviewed changes

kroikie deleted the auto-user-agent-version branch June 13, 2019 15:09

collinjackson added a commit to collinjackson/plugins that referenced this pull request Jun 13, 2019

Revert "[firebase_core] Automate version retrieval (flutter#1733)"

7c7de2b

This reverts commit 1e01c9e.

collinjackson added a commit that referenced this pull request Jun 13, 2019

[firebase_core] roll back to 0.4.0+3 (#1742)

11c4976

* Revert "[firebase_core] Automate version retrieval (#1733)" This reverts commit 1e01c9e. * Update versions and CHANGELOG to call this version 0.4.0+5

Salakar mentioned this pull request Jun 13, 2019

[firebase_core] roll back to 0.4.0+3 #1742

Merged

kroikie mentioned this pull request Jun 16, 2019

Auto retrieve version to report user agent #1748

Merged

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

[firebase_core] Automate version retrieval (flutter#1733)

aec343d

* Automate version retrieval

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[firebase_core] Automate version retrieval #1733

[firebase_core] Automate version retrieval #1733

Uh oh!

kroikie commented Jun 12, 2019

Uh oh!

collinjackson left a comment •

edited

Loading

Uh oh!

collinjackson Jun 12, 2019

Uh oh!

kroikie Jun 13, 2019

Uh oh!

collinjackson Jun 12, 2019

Uh oh!

kroikie Jun 13, 2019

Uh oh!

Salakar Jun 13, 2019

Uh oh!

Salakar Jun 13, 2019

Uh oh!

Salakar Jun 13, 2019 •

edited

Loading

Uh oh!

Salakar Jun 13, 2019

Uh oh!

ened commented Jun 13, 2019

Uh oh!

Uh oh!

[firebase_core] Automate version retrieval #1733

[firebase_core] Automate version retrieval #1733

Uh oh!

Conversation

kroikie commented Jun 12, 2019

Description

Uh oh!

collinjackson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

collinjackson Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

kroikie Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

collinjackson Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

kroikie Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

Salakar Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

Salakar Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

Salakar Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Salakar Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

ened commented Jun 13, 2019

Uh oh!

Uh oh!

collinjackson left a comment •

edited

Loading

Salakar Jun 13, 2019 •

edited

Loading