Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[Connectivity][Android] Updated check network info logic #1761

Merged
merged 3 commits into from
Jul 9, 2019
Merged

[Connectivity][Android] Updated check network info logic #1761

merged 3 commits into from
Jul 9, 2019

Conversation

arok
Copy link
Contributor

@arok arok commented Jun 19, 2019

Description

Regards to the issue https://issuetracker.google.com/issues/37137911 this PR do not use ConnectivityManager.EXTRA_NETWORK_INFO to determine current network state.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@sante85
Copy link

sante85 commented Jun 19, 2019

Please you can add PR #1727 ?

Best regards

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM! Please also update the version in the pubspec and add CHANGELOG

@cyanglaz cyanglaz added the submit queue The Flutter team is in the process of landing this PR. label Jul 8, 2019
@arok
Copy link
Contributor Author

arok commented Jul 9, 2019

@cyanglaz done

@cyanglaz cyanglaz self-assigned this Jul 9, 2019
@cyanglaz cyanglaz merged commit 2363544 into flutter:master Jul 9, 2019
@sante85
Copy link

sante85 commented Jul 10, 2019

Thanks

mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants