Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_dynamic_links] Allow FDL plugin to be registered without an activity #1835

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Jul 11, 2019

Some apps do not have an activity available when they register plugins. We should still register the plugin and leave it up to the intent listener to grab the latest intent.

@mehmetf mehmetf requested a review from bparrishMines as a code owner July 11, 2019 00:53
@collinjackson collinjackson changed the title Allow FDL plugin to be registered without an activity [firebase_dynamic_links] Allow FDL plugin to be registered without an activity Jul 11, 2019
@mehmetf
Copy link
Contributor Author

mehmetf commented Jul 11, 2019

@bparrishMines Ping for a quick review. This change is already made internally since it was breaking a team. We need to submit it upstream asap. Thanks!

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetf mehmetf merged commit fb9a4b5 into flutter:master Jul 11, 2019
@mehmetf mehmetf deleted the b70 branch July 11, 2019 17:56
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants